Update mysqli tests to work with newer MySQL server #6729
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* @@session.old_passwords is present only in 5.6 and 5.7. Newer versions already behave as if they have old_passwords=2. * SET PASSWORD FOR ... = PASSWORD(...) syntax was removed in 8.0. For all affected tests, versions that don't support newer SQL are already explicitly excluded with version checks.
nikic
reviewed
Mar 1, 2021
| die(sprintf("skip SET PASSWORD failed [%d] %s", $link->errno, $link->error)); | ||
| } | ||
|
|
||
| if (!$link->query("DROP TABLE IF EXISTS test") || | ||
| !$link->query("CREATE TABLE test (id INT)") || | ||
| if (!$link->query("CREATE TABLE test (id INT)") || |
There was a problem hiding this comment.
Why did the drop table get dropped here?
There was a problem hiding this comment.
I've merged this PR without this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
already behave as if they have old_passwords=2.
For all affected tests, versions that don't support newer SQL are
already explicitly excluded with version checks.